linux-kernel - Re: [PATCH -mm 09/15] add some sanity checks to get_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 May 2008 15:42:59 +0900
From:	"MinChan Kim" <minchan.kim@...il.com>
To:	"Rik van Riel" <riel@...hat.com>
Cc:	linux-kernel@...r.kernel.org, lee.schermerhorn@...com,
	akpm@...ux-foundation.org, kosaki.motohiro@...fujitsu.com
Subject: Re: [PATCH -mm 09/15] add some sanity checks to get_scan_ratio

On Thu, May 15, 2008 at 10:12 PM, Rik van Riel <riel@...hat.com> wrote:
> On Thu, 15 May 2008 15:34:51 +0900
> "MinChan Kim" <minchan.kim@...il.com> wrote:
>
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
>> @@ -1375,8 +1375,7 @@ static unsigned long shrink_zone(int priority, struct zon
>>          * rebalance the anon lru active/inactive ratio.
>>          */
>>         if (scan_global_lru(sc) && inactive_anon_low(zone))
>> -               shrink_list(NR_ACTIVE_ANON, SWAP_CLUSTER_MAX, zone, sc,
>> -                                                               priority);
>> +               shrink_inactive_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0);
>>
>>         throttle_vm_writeout(sc->gfp_mask);
>>         return nr_reclaimed;
>
> shrink_active_list, but yes, that is the idea.

But you used argument with NR_ACTIVE_ANON during call shrink_list.
I think It is not your intention.
So, you have to change LRU_ACTIVE_ANON or call shrink_active_list directly.




-- 
Kinds regards,
MinChan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/