linux-kernel - [patch] drivers/media/video build fix for certain modular builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080516071029.GA13147@elte.hu>
Date:	Fri, 16 May 2008 09:10:29 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>
Cc:	linux-kernel@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>
Subject: [patch] drivers/media/video build fix for certain modular builds


testing of the -tip tree found the following missing symbols build bug:

    LD      init/built-in.o
    LD      .tmp_vmlinux1
    drivers/built-in.o: In function `vidioc_g_ctrl':
    radio-maxiradio.c:(.text+0xd3337): undefined reference to `video_devdata'
    drivers/built-in.o: In function `vidioc_g_frequency':
    radio-maxiradio.c:(.text+0xd3368): undefined reference to `video_devdata'
    drivers/built-in.o: In function `vidioc_s_ctrl':
    [...]

which happens if certain media drivers are modular:

    http://redhat.com/~mingo/misc/config-Thu_May_15_18_10_27_CEST_2008.bad

the problem is:

    CONFIG_VIDEO_MEDIA=m
    CONFIG_VIDEO_DEV=y
    CONFIG_RADIO_MAXIRADIO=y
    CONFIG_VIDEO_V4L2=y

Connecting the build dependencies tree from drivers/media/ to 
drivers/media/video/ allows the built-in drivers(s) to pick up the 
CONFIG_VIDEO_DEV=y symbols.

---
 drivers/media/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/media/Makefile
===================================================================
--- linux.orig/drivers/media/Makefile
+++ linux/drivers/media/Makefile
@@ -2,7 +2,7 @@
 # Makefile for the kernel multimedia device drivers.
 #
 
-obj-y := common/
+obj-y := common/ video/
 
 obj-$(CONFIG_VIDEO_MEDIA) += common/
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/