linux-kernel - Re: [PATCH] x86: Get irq for hpet timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 May 2008 13:23:52 +0530
From:	"Balaji Rao R" <balajirrao@...il.com>
To:	"Kevin Hao" <kexin.hao@...driver.com>
Cc:	venkatesh.pallipadi@...el.com, clemens@...isch.de,
	bob.picco@...com, mingo@...hat.com, tglx@...utronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: Get irq for hpet timer

On Fri, May 16, 2008 at 11:35 AM, Kevin Hao <kexin.hao@...driver.com> wrote:
>
> Hi,
>
> x86: get irq for hpet timer
>
> HPET timer's IRQ is 0 by default, so we have to select which irq
> will be used for these timers. We wait to set the timer's irq until
> we really turn on interrupt in order to reduce the chance of
> conflicting with some legacy device.
>
Yes, this is alright. But  i've seen some machines where we have a
valid IRQ in 'devp->hd_hdwirq' which you should not ignore. So, first
check if it is zero and only then do a hpet_timer_get_irq.

--
warm regards

Balaji Rao
NITK Surathkal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/