linux-kernel - Re: [PATCH] crypto: make michael

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1210925405.4000.3.camel@johannes.berg>
Date:	Fri, 16 May 2008 10:10:05 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Sebastian Siewior <lkml@...breakpoint.cc>
Cc:	Harvey Harrison <harvey.harrison@...il.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: make michael_block a function

On Fri, 2008-05-16 at 09:01 +0200, Sebastian Siewior wrote:
> * Harvey Harrison | 2008-05-15 23:17:17 [-0700]:
> 
> >Make the michael_block macro a function and change the calling
> >function to take a struct michael_mic_ctx * and the value for
> >the initial xor with ctx->l.
> >
> >Also open-code xswap in its one use in michael_block.
> Does this change have any performance impact?
> The only user is wireless (I guess). Is it used frequently (sign every
> packet for instance) or once in a while (in every re-keying)?

Every packet. I have no idea whether it has performance impact, very
hard to even guess.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)