linux-kernel - Re: [RFC] x86: merge nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.55.0805172148380.10067@cliff.in.clinika.pl>
Date:	Sat, 17 May 2008 21:52:27 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Tom Spink <tspink@...il.com>
cc:	Cyrill Gorcunov <gorcunov@...il.com>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Slaby <jirislaby@...il.com>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [RFC] x86: merge nmi_32-64 to nmi.c

On Sat, 17 May 2008, Tom Spink wrote:

> static inline unsigned int get_nmi_count(int cpu)
> {
> #ifdef CONFIG_X86_64
>         return cpu_pda(cpu)->__nmi_count;
> #else
>         return nmi_count(cpu);
> #endif
> }
> 
> I know it introduces a lot of these conditionals, but at least there
> is one place to look for the get_nmi_count function, instead of
> searching for all variants of the function.

 Well, I suppose some header should provide a definition like:

#ifdef CONFIG_X86_64
#define cpu_x86_64 1
#else
#define cpu_x86_64 0
#endif

and the you can remove the horrible #ifdef clutter and make the quoted 
function look like:

static inline unsigned int get_nmi_count(int cpu)
{
	return cpu_x86_64 ? cpu_pda(cpu)->__nmi_count : nmi_count(cpu);
}

Much better -- isn't it?

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/