linux-kernel - Re: ext3_dx_add_entry: Directory index full!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1211125179.21380.2.camel@pmac.infradead.org>
Date:	Sun, 18 May 2008 16:39:39 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Bernie Innocenti <bernie@...ewiz.org>
Cc:	lkml <linux-kernel@...r.kernel.org>, ext3-users@...hat.com,
	ext2-devel@...ts.sourceforge.net,
	Stefano Fedrigo <aleph@...eler.com>
Subject: Re: ext3_dx_add_entry: Directory index full!

On Sun, 2008-05-18 at 17:36 +0200, Bernie Innocenti wrote:
> 
> 
>   static inline unsigned dx_root_limit (struct inode *dir, unsigned
> infosize)
>   {
>       unsigned entry_space = dir->i_sb->s_blocksize -
> EXT3_DIR_REC_LEN(1) -
>           EXT3_DIR_REC_LEN(2) - infosize;
>       return 0? 20: entry_space / sizeof(struct dx_entry);
>   }
> 
> Am I reading the above code correctly?  Why does it always return
> 20 no matter what?

It doesn't. "condition?A:B" will return A if the condition is _true_,
which it isn't.

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/