linux-kernel - Re: [patch] snd-pcsp: silent misleading warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 May 2008 18:28:50 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Stas Sergeev <stsp@...et.ru>
Cc:	Roberto Oppedisano <roberto.oppedisano@...racom.it>,
	LKML <linux-kernel@...r.kernel.org>, alsa-devel@...a-project.org
Subject: Re: [patch] snd-pcsp: silent misleading warning

At Sun, 18 May 2008 21:32:39 +0400,
Stas Sergeev wrote:
> 
> Hello.
> 
> Takashi Iwai wrote:
> >>> [  417.338143] PCSP: playback_ptr inconsistent (4642 4661 18645)
> >> It turns out that the buffer size you
> >> get, is not evenly devided by period size.
> >> 18645 % 4661 = 1.
> >> That (wrongly) triggers the warning.
> >> This may very well be an alsa bug, or
> >> may not, but the code in the driver is
> >> handling that properly, so there is no
> >> need for such a verbose warning.
> > The right fix would be to add a hw_constraint to align the buffer
> > size.  The simplest way is to add the following in PCM open callback.
> But what does this fix? That's only a
> warning, the driver itself doesn't care
> at all. The fix you propose, will need
> more testing, at least a confirmation
> from the reporter. I simply thought this
> can't happen. Now you say its a perfectly
> sane situation, and then there is nothing
> to care about, just shut up the warning.
> No?

Well, judging from your previous comment, I thought that it's no sane
situation for *your* driver.  But if the driver doesn't care in
practice, your fix should be fine.  I'll queue it on my tree. 

thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/