linux-kernel - Re: [RFC] x86: merge nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <483076FA.9040605@goop.org>
Date:	Sun, 18 May 2008 19:35:38 +0100
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Andi Kleen <andi@...stfloor.org>
CC:	Adrian Bunk <bunk@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Tom Spink <tspink@...il.com>,
	Cyrill Gorcunov <gorcunov@...il.com>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Slaby <jirislaby@...il.com>,
	Sam Ravnborg <sam@...nborg.org>
Subject: Re: [RFC] x86: merge nmi_32-64 to nmi.c

Andi Kleen wrote:
> The whole idea was pretty bad. Ifdefs are not ugly because the syntax
> looks ugly, but because it's a semantically ugly construct with bad
> maintainability impact.
>
> Trying to put syntactical sugar around that is a doomed exercise. It
> will be still ugly, no matter what you do.

Not true.  Using C rather than CPP to control the compilation of config 
options has the big win that all code paths are still visible to the 
compiler.  In some cases that's not what you want, but it often is, and 
it would avoid some degree if inadvertent breakage of options.  It can 
also be syntactically a lot more pleasant.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/