linux-kernel - Re: Regression- XFS won't mount on partitioned md array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <482FBD4C.20608@sandeen.net>
Date:	Sun, 18 May 2008 00:23:24 -0500
From:	Eric Sandeen <sandeen@...deen.net>
To:	David Greaves <david@...eaves.com>
CC:	David Chinner <dgc@....com>, xfs@....sgi.com,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: Regression- XFS won't mount on partitioned md array

Eric Sandeen wrote:
> Eric Sandeen wrote:
> 
>> I'll see if I have a little time today to track down the problem.
> 
> 
> Does this patch fix it for you?  Does for me though I can't yet explain
> why ;)
> 
> http://www.linux.sgi.com/archives/xfs/2008-05/msg00190.html
> 
> -Eric

So what's happening is that xfs is trying to read a page-sized IO from
the last sector of the log... which goes off the end of the device.
This looks like another regression introduced by
a9759f2de38a3443d5107bddde03b4f3f550060e, but fixed by Christoph's patch
in the URL above, which should be headed towards -stable.

(aside: it seems that this breaks any external log setup where the log
consists of the entire device... but I'd have expected the xfsqa suite
to catch this...?)

The patch avoids the problem by looking for some extra locking but it
seems to me that the root cause is that the buffer being read at this
point doesn't have it's b_offset, the offset in it's page, set.  Might
be another little buglet but harmless it seems.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/