linux-kernel - Re: [PATCH] virtio_net: free transmit skbs in a timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <482FCF45.1050307@qumranet.com>
Date:	Sun, 18 May 2008 09:40:05 +0300
From:	Avi Kivity <avi@...ranet.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	Mark McLoughlin <markmc@...hat.com>,
	Anthony Liguori <aliguori@...ibm.com>,
	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH] virtio_net: free transmit skbs in a timer

Rusty Russell wrote:
> On Friday 16 May 2008 01:32:47 Avi Kivity wrote:
>   
>> Mark McLoughlin wrote:
>>     
>>> I think Rusty is speaking from the POV of the guest driver - i.e. that
>>> virtio_net should never disable notifications on the xmit queue using
>>> disable_cb()?
>>>
>>> Sounds like you think agree, but that the host side should throttle the
>>> rate of xmit notifications?
>>>       
>> Yes.
>>     
>
> But performance is going to suck in the meantime, as currently our host 
> doesn't do this.
>   

That's what the feature bits are for.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/