linux-kernel - Re: [PATCH 1/1] mtd maps - Blackfin Async Flash Maps (try #4): Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080519111851.GA32679@logfs.org>
Date:	Mon, 19 May 2008 13:18:51 +0200
From:	Jörn Engel <joern@...fs.org>
To:	Bryan Wu <cooloney@...nel.org>
Cc:	dwmw2@...radead.org, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Mike Frysinger <vapier.adi@...il.com>
Subject: Re: [PATCH 1/1] mtd maps - Blackfin Async Flash Maps (try #4): Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank

On Mon, 19 May 2008 18:32:24 +0800, Bryan Wu wrote:
> 
> [try #4]
>  - drop superfluous casts
>  - drop SSYNC() when reading from the flash and rewrite
>    bfin_copy_from() to be like bfin_copy_to() so that
>    we dont have to handle all the aligned/unaligned cases
> 
> [try #3] rename bf5xx-flash to bfin-async-flash
>  - move all kconfig board settings into board resources
>  - fixup casting style according to lkml feedback
>  - rewrite driver so that it can handle arbitrary of
>    instances according to the declared platform resources
> 
> [try #2]
> Remove useless SSYNC() as Will said
> 
> [try #1]
> The BF533-STAMP does this for example.
> All board-specific configuration goes in your board resources file.
> 
> Signed-off-by: Mike Frysinger <vapier.adi@...il.com>
> Cc: Joern Engel <joern@...fs.org>
> Signed-off-by: Bryan Wu <cooloney@...nel.org>

Looks good to me.  If dwmw2 doesn't mind adding another mapping driver,
this can go in.  Not that I had any idea how physmap could sanely cover
this driver too.

Acked-By: Joern Engel <joern@...fs.org>

Jörn

-- 
Ninety percent of everything is crap.
-- Sturgeon's Law
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/