linux-kernel - Re: [PATCH] [1/11] Remove BKL from remote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48319901.2080809@firstfloor.org>
Date:	Mon, 19 May 2008 17:13:05 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Christoph Hellwig <hch@...radead.org>
CC:	Trond.Myklebust@...app.com, swhiteho@...hat.com, sfrench@...ba.org,
	vandrove@...cvut.cz, corbet@....net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [1/11] Remove BKL from remote_llseek


> Your new remote_llseek_unlocked is the same as generic_file_llseek
> except for the fact that it doesn't take i_mutex.  So I'd rather
> call it generic_file_llseek_nolock and make generic_file_llseek call
> it.  

Done. There's also default_llseek btw which is nearly similar, 
but i didn't touch that one.

> While you're at it you could also add some kerneldoc documents
> describing them.

Off topic for the series, left that to someone else.

-Andi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/