linux-kernel - ext4-mm-delalloc-ext4-lock-reverse-fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1211210687-4212-1-git-send-email-jirislaby@gmail.com>
Date:	Mon, 19 May 2008 17:24:47 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	adobriyan@...il.com, "Dave Young" <hidave.darkstar@...il.com>,
	linux-kernel@...r.kernel.org, Mingming Cao <cmm@...ibm.com>,
	Jiri Slaby <jirislaby@...il.com>
Subject: ext4-mm-delalloc-ext4-lock-reverse-fix

Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Mon, 19 May 2008 15:15:09 +0800 "Dave Young" <hidave.darkstar@...il.com> wrote:
> 
> > Hi,
> > 
> > With 2.6.26-rc2-mm1 I need to sync frequently. It's not normal as my
> > understanding.
> > 
> > 1. scp a big file from a lan server. Firstly the speed is about 8M/s,
> > but the speed will slow down to 100K/s at last. After I exec "sync",
> > the speed will restore.
> > 
> > Is this a known issue?
> > 
> 
> Yes, probably related to the "mkfs takes forever" problem.  I haven't
> looked into it yet.  Nor has anyone else afaik.

Absolutely not sure what this breaks in ext4, but fixes the problem for me:
---
 mm/page-writeback.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 040bc7c..789b6ad 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -881,7 +881,7 @@ int write_cache_pages(struct address_space *mapping,
 	pagevec_init(&pvec, 0);
 	if (wbc->range_cyclic) {
 		index = mapping->writeback_index; /* Start from prev offset */
-		end = wbc->range_end >> PAGE_CACHE_SHIFT;
+		end = -1;
 	} else {
 		index = wbc->range_start >> PAGE_CACHE_SHIFT;
 		end = wbc->range_end >> PAGE_CACHE_SHIFT;
-- 
1.5.4.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/