| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LFD.1.10.0805190929170.32253@woody.linux-foundation.org> Date: Mon, 19 May 2008 09:36:56 -0700 (PDT) From: Linus Torvalds <torvalds@...ux-foundation.org> To: Boaz Harrosh <bharrosh@...asas.com> cc: Alan Stern <stern@...land.harvard.edu>, Maciej Rutecki <maciej.rutecki@...il.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, USB list <linux-usb@...r.kernel.org>, USB Storage list <usb-storage@...ts.one-eyed-alien.net>, SCSI development list <linux-scsi@...r.kernel.org> Subject: Re: [Re: Linux 2.6.26-rc2] Write protect on on On Mon, 19 May 2008, Boaz Harrosh wrote: > Alan Stern wrote: > > > > Yes, it never worked properly. But now it fails in a bad way whereas > > before it failed in a benign way. > > You do realize that, that was pure lock to have a zero'ed buffer. Umm. Maybe it SHOULD NOT HAVE BEEN! The thing is, if we can get partial results back, we really *should* either error out, or we should have at least cleared the buffer (either beforehand or when seeing the partial result). Returning a buffer with the old random contents is a bug. And if clearing the buffer not only avoids any security holes and possible undefined behavior, but _also_ ends up fixing the write protect sense issue, all the better! Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists