linux-kernel - Re: [PATCH, RFC] Char dev BKL pushdown v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4831D484.10505@s5r6.in-berlin.de>
Date:	Mon, 19 May 2008 21:27:00 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Jonathan Corbet <corbet@....net>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Alexander Viro <viro@....linux.org.uk>,
	linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH, RFC] Char dev BKL pushdown v2

I wrote:
> Jonathan Corbet wrote:
>>  drivers/ieee1394/dv1394.c                    |    6 +++-
>>  drivers/ieee1394/raw1394.c                   |    3 ++
>>  drivers/ieee1394/video1394.c                 |   18 +++++++++---
> ...
>>       ieee1394: cdev lock_kernel() pushdown
> 
> I have yet to look at these drivers in detail whether they need BKL or 
> not.  They likely don't.

video1394 needs it to serialize module init vs. open.  The race 
condition there can be prevented by splitting hpsb_register_highlevel() 
into an _init and a _register function.  I will follow up with a patch.

dv1394 and raw1394 do not need the BKL in their open() methods AFAICS.
-- 
Stefan Richter
-=====-==--- -=-= =--==
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/