linux-kernel - Re: [PATCH 1/1] [libata] pata-bf54x: Set ATAPI host state machine to control IDE device terminate sequence.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4831F442.1010600@pobox.com>
Date:	Mon, 19 May 2008 17:42:26 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Bryan Wu <cooloney@...nel.org>
CC:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH 1/1] [libata] pata-bf54x: Set ATAPI host state machine
 to control IDE device terminate sequence.

Bryan Wu wrote:
> From: Sonic Zhang <sonic.zhang@...log.com>
> 
> Set ATAPI host state machine to control IDE device terminate sequence.
> Some IDE harddisk may assert terminate sequence in the middle of a
> formal DMA transaction and resume later. Bit DETECT_TERM in ATAPI_CTRL
> register determines whether the ATAPI host state machine or the kernel
> driver should take care of this case.
> 
> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
> Signed-off-by: Bryan Wu <cooloney@...nel.org>
> ---
>  drivers/ata/pata_bf54x.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/ata/pata_bf54x.c b/drivers/ata/pata_bf54x.c
> index 9ab8973..5551610 100644
> --- a/drivers/ata/pata_bf54x.c
> +++ b/drivers/ata/pata_bf54x.c
> @@ -911,7 +911,10 @@ static void bfin_bmdma_start(struct ata_queued_cmd *qc)
>  	/* Reset all transfer count */
>  	ATAPI_SET_CONTROL(base, ATAPI_GET_CONTROL(base) | TFRCNT_RST);
>  
> -		/* Set transfer length to buffer len */
> +	/* Set ATAPI state machine contorl in terminate sequence */
> +	ATAPI_SET_CONTROL(base, ATAPI_GET_CONTROL(base) | END_ON_TERM);
> +
> +	/* Set transfer length to buffer len */
>  	for_each_sg(qc->sg, sg, qc->n_elem, si) {

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/