linux-kernel - Re: [2.6 patch] asm-generic/int-ll64.h: always provide _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1211236048.5915.94.camel@brick>
Date:	Mon, 19 May 2008 15:27:28 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Adrian Bunk <bunk@...nel.org>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [2.6 patch] asm-generic/int-ll64.h: always provide __{s,u}64

On Mon, 2008-05-19 at 15:01 -0700, H. Peter Anvin wrote:
> Adrian Bunk wrote:
> > Several compilers offer "long long" without claiming to support C99.
> > 
> > Considering how frequent __s64/__u64 are used our userspace headers are 
> > anyway unusable without __s64/__u64 available.
> > 
> > Always offer __s64/__u64 to non-gcc non-C99 compilers - if they provide 
> > "long long" that makes the headers compiling and if they don't they are 
> > anyway screwed.
> > 
> > Signed-off-by: Adrian Bunk <bunk@...nel.org>
> 
> This makes sense to me (I did, however, not want to make that change 
> part of the same changeset - one change at a time.)
> 
> The main reason for not just blindly using "long long" has to do with 
> the use of gcc -ansi -pedantic in userspace, which is already taken care 
> of by the use of __extension__ in the __GNUC__ clause.
> 

If it is going to be unconditionally offered, we could get rid of
__BYTEORDER_HAS_U64__ as a next step.  Unless there is something I've
missed.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/