linux-kernel - Re: [patch 2/4] PNP: replace pnp_resource_table with dynamically allocated resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <483209BF.3040208@keyaccess.nl>
Date:	Tue, 20 May 2008 01:14:07 +0200
From:	Rene Herman <rene.herman@...access.nl>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
CC:	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Adam Belay <ambx1@....rr.com>,
	Adam M Belay <abelay@....edu>,
	Li Shaohua <shaohua.li@...el.com>,
	Matthieu Castet <castet.matthieu@...e.fr>,
	Thomas Renninger <trenn@...e.de>,
	Jaroslav Kysela <perex@...ex.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Takashi Iwai <tiwai@...e.de>
Subject: Re: [patch 2/4] PNP: replace pnp_resource_table with dynamically
 allocated resources

On 16-05-08 00:07, Bjorn Helgaas wrote:

> PNP used to have a fixed-size pnp_resource_table for tracking the
> resources used by a device.  This table often overflowed, so we've
> had to increase the table size, which wastes memory because most
> devices have very few resources.
> 
> This patch replaces the table with a linked list of resources where
> the entries are allocated on demand.

[ ... ]

>  static void pnp_clean_resource_table(struct pnp_dev *dev)
>  {
> -	struct resource *res;
> -	int idx;
> +	struct pnp_resource *pnp_res, *tmp;
>  
> -	for (idx = 0; idx < PNP_MAX_IRQ; idx++) {
> -		res = &dev->res->irq[idx].res;
> -		if (res->flags & IORESOURCE_AUTO) {
> -			res->flags = IORESOURCE_IRQ;
> -			pnp_init_resource(res);
> -		}
> -	}
> -	for (idx = 0; idx < PNP_MAX_DMA; idx++) {
> -		res = &dev->res->dma[idx].res;
> -		if (res->flags & IORESOURCE_AUTO) {
> -			res->flags = IORESOURCE_DMA;
> -			pnp_init_resource(res);
> -		}
> -	}
> -	for (idx = 0; idx < PNP_MAX_PORT; idx++) {
> -		res = &dev->res->port[idx].res;
> -		if (res->flags & IORESOURCE_AUTO) {
> -			res->flags = IORESOURCE_IO;
> -			pnp_init_resource(res);
> -		}
> -	}
> -	for (idx = 0; idx < PNP_MAX_MEM; idx++) {
> -		res = &dev->res->mem[idx].res;
> -		if (res->flags & IORESOURCE_AUTO) {
> -			res->flags = IORESOURCE_MEM;
> -			pnp_init_resource(res);
> -		}
> +	list_for_each_entry_safe(pnp_res, tmp, &dev->resources, list) {
> +		if (pnp_res->res.flags & IORESOURCE_AUTO)
> +			pnp_free_resource(pnp_res);
>  	}
>  }


Do correct me if I'm wrong but I don't believe this will do. The index 
for the resources is preserved simply due to the list position after the 
DISABLED thing but here the list is reshuffled.

So say I have an ISAPnP device with 2 port resources the second of which 
I force to manual setting through sysfs (ie, AUTO is cleared). This API 
would then delete the first port resource after which the second port 
resource is the first entry in the list which would make for example 
isapnp_set_resource() program it into hardware index 1, no?

This function would appear to be unimplementable now? It's called from 
pnp_assign_resources() and pnp_disable_dev().

(stopped review there, since it seems this needs to either change or you 
need to slap some sense into me first)

Rene.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/