linux-kernel - Re: [PATCH] virtio_net: free transmit skbs in a timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200805191152.28409.rusty@rustcorp.com.au>
Date:	Mon, 19 May 2008 11:52:27 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Avi Kivity <avi@...ranet.com>
Cc:	Mark McLoughlin <markmc@...hat.com>,
	Anthony Liguori <aliguori@...ibm.com>,
	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH] virtio_net: free transmit skbs in a timer

On Monday 19 May 2008 00:27:05 Avi Kivity wrote:
> Rusty Russell wrote:
> > OK.  And since the current situation is that the host doesn't throttle,
> > the feature bit should be "don't throttle, host is doing it for you", and
> > Mark's patch should go in...
>
> Yes.
>
> We should have thought of this before, though, especially as Xen does
>
> this or something very similar:
> > /* Shared ring page */                            \
> > struct __name##_sring {                            \
> >     RING_IDX req_prod, req_event;                    \
> >     RING_IDX rsp_prod, rsp_event;                    \
> >     uint8_t  pad[48];                            \
> >     union __name##_sring_entry ring[1]; /* variable-length */        \
> > };                                    \
>
> req_event and rsp_event allow the other side to indicate when it wants a
> notification.

Well, we do have such a thing, in the ring suppression flags.  Note that DaveM 
is talking about moving network tx queue into the net drivers themselves, 
which will make them much more efficient (ie. drain entire queue before 
kick), which may again change the balance of what the Right Thing is.

I'll merge Mark's patch, and look at hacking up a feature to change behaviour 
to never suppress tx-done interrupts.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/