linux-kernel - Re: [patch 07/22] fat: dont call notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E1Jy05W-0007cv-UK@pomaz-ex.szeredi.hu>
Date:	Mon, 19 May 2008 09:47:18 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	flar@...andria.com
CC:	miklos@...redi.hu, hirofumi@...l.parknet.co.jp,
	akpm@...ux-foundation.org, hch@...radead.org,
	viro@...IV.linux.org.uk, ezk@...sunysb.edu,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 07/22] fat: dont call notify_change

> > +EXPORT_SYMBOL_GPL(security_inode_setattr);
> 
> Is there any particular reason you made it EXPORT_SYMBOL_GPL? It seems
> like this is replacing functionality that was previously exported
> without a GPL tag. I won't argue forcefully for changing it, but I
> did want to mention it on the list. I understand people wanting to
> make new functionality tagged that way (even though I disagree), but
> this doesn't seem to fit either the notion of an internal thing that
> shouldn't be touched or new functionality.

It's an internal thing: no other filesystem should do this (and IMO
even FAT should not, but some people seem to feel otherwise).

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/