| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <12112747762255-git-send-email-swhiteho@redhat.com> Date: Tue, 20 May 2008 10:12:44 +0100 From: swhiteho@...hat.com To: linux-kernel@...r.kernel.org, cluster-devel@...hat.com Cc: Jean Delvare <khali@...ux-fr.org>, Steven Whitehouse <swhiteho@...hat.com> Subject: [PATCH 3/3] [GFS2] Prefer strlcpy() over snprintf() From: Jean Delvare <khali@...ux-fr.org> strlcpy is faster than snprintf when you don't use the returned value. Signed-off-by: Jean Delvare <khali@...ux-fr.org> Signed-off-by: Steven Whitehouse <swhiteho@...hat.com> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index ef9c6c4..b2028c8 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -142,8 +142,8 @@ static int init_names(struct gfs2_sbd *sdp, int silent) if (!table[0]) table = sdp->sd_vfs->s_id; - snprintf(sdp->sd_proto_name, GFS2_FSNAME_LEN, "%s", proto); - snprintf(sdp->sd_table_name, GFS2_FSNAME_LEN, "%s", table); + strlcpy(sdp->sd_proto_name, proto, GFS2_FSNAME_LEN); + strlcpy(sdp->sd_table_name, table, GFS2_FSNAME_LEN); table = sdp->sd_table_name; while ((table = strchr(table, '/'))) -- 1.5.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists