linux-kernel - Re: [PATCH] Add support for HTC Shift Touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4832AFCA.30701@eslack.org>
Date:	Tue, 20 May 2008 13:02:34 +0200
From:	Pau Oliva Fora <pau@...ack.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org
Subject: Re: [PATCH] Add support for HTC Shift Touchscreen

Dmitry Torokhov wrote:
> On Tue, May 20, 2008 at 01:08:44AM +0200, Pau Oliva Fora wrote:
>> +
>> +static int htcpen_open(struct input_dev *dev)
>> +{
>> +	outb_p(DEVICE_ENABLE, HTCPEN_PORT_INIT);
>> +	return 0;
>> +}
>> +
>> +static void htcpen_close(struct input_dev *dev)
>> +{
>> +	free_irq(HTCPEN_IRQ, dev);
>> +}
>> +
> 
> No, this will not work.. next time you open the device you won't have
> IRQ anymore. You need the opposite of outb_p(DEVICE_ENABLE,
> HTCPEN_PORT_INIT); here.
> 

It is actually working; it also works after suspend/resume without any
issues.

I currently do not know a safe way of disabling the device, as HTC did
not offer any specifications or datasheet when I requested, so everything
in the driver has been reverse engineered.

Let me know if you think it's ok to leave it as is, otherwise I'll try
to find the proper way to disable the device (it should not be much
different than the way of enabling it).

Best Regards,

	Pau Oliva
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/