linux-kernel - Re: aperture_64: use symbolic constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 20 May 2008 13:20:02 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Pavel Machek <pavel@...e.cz>
Cc:	Ingo Molnar <mingo@...e.hu>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: aperture_64: use symbolic constants

Pavel Machek <pavel@...e.cz> writes:
>  		if ((last_aper_order && aper_order != last_aper_order) ||
> @@ -303,9 +303,9 @@ void __init early_gart_iommu_check(void)
>  		if (!early_is_k8_nb(read_pci_config(0, num, 3, 0x00)))
>  			continue;
>  
> -		ctl = read_pci_config(0, num, 3, 0x90);
> +		ctl = read_pci_config(0, num, 3, AMD64_GARTAPERTURECTL);

Strictly "AMD64_" is not the correct prefix, because these registers
are generic standard AGP3 registers.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/