linux-kernel - Re: [PATCH] Make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0805200752580.32253@woody.linux-foundation.org>
Date:	Tue, 20 May 2008 07:54:10 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Dave Jones <davej@...hat.com>
cc:	Arjan van de Ven <arjan@...radead.org>,
	Matthew Wilcox <matthew@....cx>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Make



On Tue, 20 May 2008, Dave Jones wrote:
> 
> Like this ?  (I don't have a -mm handy, so guessed based on mm-commits mail,
>   patch uncompiled, but should dtrt if I understood your diff correctly)
> 
> diff --git a/lib/list_debug.c b/lib/list_debug.c
> index 4350ba9..d8dee53 100644
> --- a/lib/list_debug.c
> +++ b/lib/list_debug.c
> @@ -21,16 +21,14 @@ void __list_add(struct list_head *new,
>  			      struct list_head *next)
>  {
>  	if (unlikely(next->prev != prev)) {
> -		printk(KERN_ERR "list_add corruption. next->prev should be "
> +		WARN(1, "list_add corruption. next->prev should be "
>  			"prev (%p), but was %p. (next=%p).\n",
>  			prev, next->prev, next);
> -		BUG();
>  	}

I think Arjan meant like

	WARN(next->prev != prev,
		"list_add corruption. next->prev should be "
		"prev (%p), but was %p. (next=%p).\n",
		prev, next->prev, next);

without any "if()" statement at all.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/