linux-kernel - Re: [patch] fix build error in drivers/media/video/cx23885/cx2388 5-dvb.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4832F956.90708@linuxtv.org>
Date:	Tue, 20 May 2008 12:16:22 -0400
From:	mkrufky@...uxtv.org
To:	mingo@...e.hu
Cc:	mchehab@...radead.org, linux-kernel@...r.kernel.org,
	pb@...uxtv.org, Stoth@...ppauge.com, v4l-dvb-maintainer@...uxtv.org
Subject: Re: [patch] fix build error in	drivers/media/video/cx23885/cx2388
	5-dvb.c

Please see below, proper patch attached...

Ingo Molnar wrote:
> testing of the -tip tree found the following module build failure on 
> latest -git:
>
>     Building modules, stage 2.
>     MODPOST 421 modules
>     ERROR: "dib7000p_attach" [drivers/media/video/cx23885/cx23885.ko]
undefined!
>     make[1]: *** [__modpost] Error 1
>     make: *** [modules] Error 2
>
> with the following config:
>
>     http://redhat.com/~mingo/misc/config-Tue_May_20_17_13_32_CEST_2008.bad
>
> the problem is caused that ./drivers/media/video/cx23885/cx23885-dvb.c
> depends on a DVB_DIB7000P symbol (dib7000p_attach), but its Kconfig rule
> only selects it if DVB_FE_CUSTOMISE is enabled:
>
>        select DVB_DIB7000P if !DVB_FE_CUSTOMISE
>
> the minimal fix found is to select the DVB frontend driver
unconditionally.
>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---
>  drivers/media/video/cx23885/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/drivers/media/video/cx23885/Kconfig
> ===================================================================
> --- linux.orig/drivers/media/video/cx23885/Kconfig
> +++ linux/drivers/media/video/cx23885/Kconfig
> @@ -11,7 +11,7 @@ config VIDEO_CX23885
>  	select VIDEOBUF_DVB
>  	select VIDEO_CX25840
>  	select VIDEO_CX2341X
> -	select DVB_DIB7000P if !DVB_FE_CUSTOMISE
> +	select DVB_DIB7000P
>  	select MEDIA_TUNER_MT2131 if !DVB_FE_CUSTOMISE
>  	select DVB_S5H1409 if !DVB_FE_CUSTOMISE
>  	select DVB_LGDT330X if !DVB_FE_CUSTOMISE
>
>   

Ingo,

Your patch will work around a symptom of the problem, but this is not 
the proper fix.

Please see the attached patch, which should be applied, instead.

Thanks for pointing this out.

Regards,

Mike Krufky



View attachment "dib7000p-attach.patch" of type "text/plain" (1347 bytes)