linux-kernel - Re: [PATCH 05/21] drivers/usb: use aligned-endian get/put helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1211309154.5915.189.camel@brick>
Date:	Tue, 20 May 2008 11:45:53 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/21] drivers/usb: use aligned-endian get/put helpers

On Tue, 2008-05-20 at 11:06 -0700, Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---

After all that I compiled with the wrong config to make sure
it all compiled after splitting, extra bracket in devio.c

>  drivers/usb/c67x00/c67x00-hcd.c |    4 ++--
>  drivers/usb/core/devio.c        |   12 ++++++------
>  drivers/usb/gadget/net2280.c    |    2 +-
>  drivers/usb/host/ehci.h         |    6 ++----
>  drivers/usb/host/isp116x-hcd.c  |    4 ++--
>  drivers/usb/host/ohci.h         |   16 ++++++----------
>  drivers/usb/host/uhci-hub.c     |    6 +++---
>  drivers/usb/misc/auerswald.c    |    2 +-
>  drivers/usb/serial/garmin_gps.c |    9 ++++-----
>  drivers/usb/storage/isd200.c    |    4 ++--
>  10 files changed, 29 insertions(+), 36 deletions(-)
>  
> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> index de17738..b44a061 100644
> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -993,18 +993,18 @@ static int proc_do_submiturb(struct dev_state *ps, struct usbdevfs_urb *uurb,
>  			kfree(dr);
>  			return -EFAULT;
>  		}
> -		if (uurb->buffer_length < (le16_to_cpup(&dr->wLength) + 8)) {
> +		if (uurb->buffer_length < get_le16(&dr->wLength) + 8)) {
								      ^
Sorry.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/