linux-kernel - Re: [PATCH net-2.6] [NET] The world is not perfect patch.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 May 2008 10:33:35 +0300
From:	"Rami Rosen" <ramirose@...il.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-2.6] [NET] The world is not perfect patch.

Hi,
  Unless there will be any objection here, I suggest consider the
following patch which simply removes the code for the
-DI_WISH_WORLD_WERE_PERFECT in the three methods which use it.

The compilation errors we get when using -DI_WISH_WORLD_WERE_PERFECT
show that this code was not built and not used for really a long time.

Regards,
Rami Rosen

Signed-off-by: Rami Rosen <ramirose@...il.com>

On Wed, May 21, 2008 at 12:33 AM, David Miller <davem@...emloft.net> wrote:
> From: "Rami Rosen" <ramirose@...il.com>
> Date: Tue, 20 May 2008 12:29:26 +0300
>
>> There are three methods in the network stack which start with
>> #ifndef I_WISH_WORLD_WERE_PERFECT.
>
> I think it is better to delete this code.  It is impossible
> for anyone to build test it without making source modifications,
> therefore it will continute to break over and over again over
> time.
>

View attachment "patch.txt" of type "text/plain" (11150 bytes)