[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8bd0f97a0805201741h13e44c4dkead97118d7d137e8@mail.gmail.com>
Date: Tue, 20 May 2008 20:41:13 -0400
From: "Mike Frysinger" <vapier.adi@...il.com>
To: "Andrew Morton" <akpm@...ux-foundation.org>
Cc: "Bryan Wu" <cooloney@...nel.org>, linux-kernel@...r.kernel.org,
michael.hennerich@...log.com
Subject: Re: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-try-2.patch added to -mm tree
On Tue, May 20, 2008 at 4:02 AM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Tue, 20 May 2008 15:51:13 +0800 "Bryan Wu" <cooloney@...nel.org> wrote:
>> Need I resend out the a new patch which fold these 3 patches together.
>> it is easier for you to maintain.
>
> Nope, I keep the patches separate and then fold them prior to sending
> to Linus.
>
> I marked this as for-2.6.26 as it's clearly non-injurious to existing stuff.
>
> This:
>
>> -#if defined(__arm__) || defined(__mips__) || defined(__avr32__)
>> +#if defined(__arm__) || defined(__mips__) || defined(__avr32__) || defined(bfin)
>
> should probably be using CONFIG_foo but that might not work if it's to
> be preprocessed by userspace. I didn't look. Plus that'd be
> off-topic.
it should be defined(__bfin__) at least. perhaps i should add that
check to checkpatch.pl as well ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists