linux-kernel - Re: [PATCH] bt8xx: unaligned access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080521004306.GC28946@ZenIV.linux.org.uk>
Date:	Wed, 21 May 2008 01:43:06 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Al Viro <viro@....linux.org.uk>, mchehab@...radead.org,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org
Subject: Re: [PATCH] bt8xx: unaligned access

On Tue, May 20, 2008 at 05:38:43PM -0700, Harvey Harrison wrote:
> > -		type = be16_to_cpup((u16*)(ee+4));
> > +		type = get_unaligned_be16((__be16 *)(ee+4));
> 
> The casts aren't strictly necessary here.  Any reason to keep it?

I'd rather have them explicit *and* make get_unaligned_* take the pointer
of right type, so that it'd eat things like void * and __be16 *, but warn
on int * et.al.  One too many brainos seen in that area...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/