linux-kernel - Re: [RFC/PATCH 2/3] SLUB: make ksize() more strict for page allocator pass-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0805211149210.16064@schroedinger.engr.sgi.com>
Date:	Wed, 21 May 2008 11:52:25 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Pekka J Enberg <penberg@...helsinki.fi>
cc:	linux-kernel@...r.kernel.org, mpm@...enic.com, lethal@...ux-sh.org,
	dhowells@...hat.com
Subject: Re: [RFC/PATCH 2/3] SLUB: make ksize() more strict for page allocator
 pass-through

On Wed, 21 May 2008, Pekka J Enberg wrote:

> This patch changes ksize() to be more strict with objets passed to it. We now
> set PageSlab also for objects allocated with page allocator and use page->slab
> to check whether page is a regular slab page or a pass-through page.
> 
> Also moves kmalloc_large() out-of-line as it's too big for inlining now.

Why is it too big? Without your additions it is converting kmallocs 
inline to get_free_pages(). That results in a simple function call with 
two constant parameters.

The patch touches the page struct uselessly. I think the PageSlab marking 
is useful for debugging but not for a production kernel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/