linux-kernel - Re: [patch 11/14] vfs: move executable checking into ->permission()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1Jyu4x-0006C8-J0@pomaz-ex.szeredi.hu>
Date:	Wed, 21 May 2008 21:34:27 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	trond.myklebust@....uio.no
CC:	miklos@...redi.hu, linux-fsdevel@...r.kernel.org,
	hch@...radead.org, viro@...IV.linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 11/14] vfs: move executable checking into ->permission()

> > No, we don't want to deny read or write (that's up to the filesystem
> > how it handles it), just want to deny execute if no x bits are set in
> > the mode.
> 
> OK, but when I see something with the name 'exec_permission()', I assume
> that it is going to check for whether or not I have execute permission.
> 
> If that is not the case, then can we please either change the function,
> or change the name?

Yeah, the name's not very good.  Especially that there's an
exec_permission_lite() in the same file, which has nothing to do with
this.

Will try to think of something better.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/