linux-kernel - Re: [RFC/PATCH 1/3] SLAB: Add PageSlab checking to ksize()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080521234555.GB32707@linux-sh.org>
Date:	Thu, 22 May 2008 08:45:55 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Pekka J Enberg <penberg@...helsinki.fi>
Cc:	linux-kernel@...r.kernel.org, clameter@....com, mpm@...enic.com,
	dhowells@...hat.com
Subject: Re: [RFC/PATCH 1/3] SLAB: Add PageSlab checking to ksize()

On Wed, May 21, 2008 at 09:25:26PM +0300, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@...helsinki.fi>
> 
> The ksize() function is meant for objects allocated from the slab caches, not
> for arbitrary objects. Add a BUG_ON() to enforce that.
> 
> Cc: Christoph Lameter <clameter@....com>
> Cc: Matt Mackall <mpm@...enic.com>
> Cc: Paul Mundt <lethal@...ux-sh.org>
> Cc: David Howells <dhowells@...hat.com>
> Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>

This series seems to work ok with all of SLAB/SLUB/SLOB when also
applying the kobjsize() patch. Without the kobjsize() patch in place,
SLAB and SLUB both work, while SLOB still triggers the >= MAX_ORDER
BUG_ON() for page cache pages. Note that this is still an improvement
over SLUB blowing up, as it was before, even without the kobjsize()
change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/