linux-kernel - Re: [PATCH 2/3][-mm] reclassify the sg_sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8e1da0805201825w4c8e35d7o55db8af9e04981df@mail.gmail.com>
Date:	Wed, 21 May 2008 09:25:58 +0800
From:	"Dave Young" <hidave.darkstar@...il.com>
To:	"Greg KH" <greg@...ah.com>
Cc:	akpm@...ux-foundation.org, matthew@....cx, kay.sievers@...y.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3][-mm] reclassify the sg_sysfs_class mutex

On Wed, May 21, 2008 at 1:22 AM, Greg KH <greg@...ah.com> wrote:
> On Tue, May 20, 2008 at 05:58:51PM +0800, Dave Young wrote:
>> [Please first apply the patch 1/3 before this]
>>
>> To please lockdep here we use class_reclassify to change
>> the lock class of sg_sysfs_class
>
> Are you suggesting we do this for every struct class in the kernel?  If
> so, why not just do it in the class core, instead of having to modify
> every single caller?

I don't think it necessary to do this for every class, because only
class_interface_* calls could cause the issue, and the
class_interface_* are only used by pcmcia & scsi, do you think there
will be other users of them?

>
> I don't think the overall idea of this patch set is acceptable anyway :(
>
> thanks,
>
> greg k-h
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/