linux-kernel - Re: [PATCH 2/3] signals: introduce SIGQUEUE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080521022440.8B23726FA1C@magilla.localdomain>
Date:	Tue, 20 May 2008 19:24:40 -0700 (PDT)
From:	Roland McGrath <roland@...hat.com>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Austin Clements <amdragon+kernelbugzilla@....edu>,
	Ingo Molnar <mingo@...e.hu>, john stultz <johnstul@...ibm.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Michael Kerrisk <mtk.manpages@...glemail.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] signals: introduce SIGQUEUE_CANCELLED

> Introduce SIGQUEUE_CANCELLED flag. If it is set, the pending signal should be
> ignored and collect_signal() should return 0.

Acked-by: Roland McGrath <roland@...hat.com>

> Note that the new flag is completely orthogonal to SIGQUEUE_PREALLOC, and it
> can be set without ->siglock held.

I think to keep things easier to understand, we should say the rule is that
touching q->flags is always controlled by siglock when q is on a queue.
Before it's queued or after it's been dequeued (i.e. list_empty(&q->list)
with siglock held), then the "owner" of the struct sigqueue of course needs
noone's siglock.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/