linux-kernel - Re: [patch v2] kmalloc returns (void*), don't do type conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200805221109.03046@marek.priv.at>
Date:	Thu, 22 May 2008 11:09:01 +0200
From:	Philipp Marek <philipp@...ek.priv.at>
To:	"Jesper Juhl" <jesper.juhl@...il.com>
Cc:	"Johannes Weiner" <hannes@...urebad.de>,
	linux-kernel@...r.kernel.org, linux-trivial@...nel.org
Subject: Re: [patch v2] kmalloc returns (void*), don't do type conversions

On Thursday 22 May 2008 Jesper Juhl wrote:
> 2008/5/21 Johannes Weiner <hannes@...urebad.de>:
> > Hi Phillip,
> >
> > Philipp Marek <philipp@...ek.priv.at> writes:
> >> I tried a "make allyesconfig", but that gave some compile errors
> >> that don't seem related to my changes:
> >>       drivers/block/cciss_scsi.c:75: error: 'MAX_CTLR' undeclared here
> >> (not in a function) drivers/block/cciss_scsi.c:76: error: field name not
> >> in record or union initializer
> >
> > You probably should write another email regarding this.
>
> I agree, keep things seperate. One mail with patch to fix casts,
> another to report build breakage.
Sorry, I didn't make myself understood.

A "make allyesconfig ; make" goes through (for amd64); just testing every file 
for itself ("make drivers/block/cciss_scsi.o") gives errors - partly because 
they're for the wrong architecture, or some other mismatches.

Please note that the first version had a bug (missing "{") which is corrected 
here.

> > Added the trivial tree maintainer to CC.  Jesper?
> Thank you, I'll keep an eye on this patch.
I didn't think that these changes were "trivial" - I'd have taken this 
category for comment updates and suchlike.
But I'm ok with that :-)

> Philipp: Johannes makes some good points, please address his comments
> and re-submit the patch with trivial@...nel.org on Cc:  if it draws no
> negative comments it looks good to me to add to the trivial tree.
Here you are.

I've got 57 other patches that deal with (void*)-returning functions getting 
casted; diffstat says
	151 files changed, 301 insertions(+), 368 deletions(-)
Should I just send them (as a whole) to trivial@ like this patch, or should I 
cut them for different maintainers?


Regards,

Phil


View attachment "kmalloc-type-changes.patch" of type "text/x-diff" (16320 bytes)