linux-kernel - Re: [PATCH] Move the second call to get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080522131036.GH7712@kernel.dk>
Date:	Thu, 22 May 2008 15:10:36 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Move the second call to get_request to the end of the loop

On Thu, May 22 2008, Zhang, Yanmin wrote:
> In function get_request_wait, the second call to get_request could be
> moved to the end of the while loop, because if the first call to
> get_request fails, the second call will fail without sleep.

Looks safe enough, since we don't drop the lock in between getting the
request and adding to the wait queue. I'll add it to the testing mix,
thanks!


-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/