linux-kernel - [CIFS] Fix reversed memset arguments.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080522130722.GA21163@redhat.com>
Date:	Thu, 22 May 2008 09:07:22 -0400
From:	Dave Jones <davej@...hat.com>
To:	Steve French <sfrench@...ibm.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: [CIFS] Fix reversed memset arguments.

size is the 3rd argument.

Signed-off-by: Dave Jones <davej@...hat.com>

--- linux-2.6/fs/cifs/inode.c~	2008-05-22 09:05:31.000000000 -0400
+++ linux-2.6/fs/cifs/inode.c	2008-05-22 09:05:58.000000000 -0400
@@ -172,7 +172,7 @@ static void fill_fake_finddataunix(FILE_
 {
 	struct inode *pinode = NULL;
 
-	memset(pfnd_dat, sizeof(FILE_UNIX_BASIC_INFO), 0);
+	memset(pfnd_dat, 0, sizeof(FILE_UNIX_BASIC_INFO));
 
 /*	__le64 pfnd_dat->EndOfFile = cpu_to_le64(0);
 	__le64 pfnd_dat->NumOfBytes = cpu_to_le64(0);
@@ -384,7 +384,7 @@ static int get_sfu_mode(struct inode *in
 static void fill_fake_finddata(FILE_ALL_INFO *pfnd_dat,
 			       struct super_block *sb)
 {
-	memset(pfnd_dat, sizeof(FILE_ALL_INFO), 0);
+	memset(pfnd_dat, 0, sizeof(FILE_ALL_INFO));
 
 /*	__le64 pfnd_dat->AllocationSize = cpu_to_le64(0);
 	__le64 pfnd_dat->EndOfFile = cpu_to_le64(0);
-- 
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/