linux-kernel - Re: [RFC][Patch 1/4]integrity: TPM internel kernel interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080522150516.GB25721@elf.ucw.cz>
Date:	Thu, 22 May 2008 17:05:17 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, safford@...son.ibm.com,
	serue@...ux.vnet.ibm.com, sailer@...son.ibm.com, zohar@...ibm.com,
	Stephen Smalley <sds@...ho.nsa.gov>,
	CaseySchaufler <casey@...aufler-ca.com>
Subject: Re: [RFC][Patch 1/4]integrity: TPM internel kernel interface

On Wed 2008-05-21 11:54:16, Mimi Zohar wrote:
> This is a request for comments for a redesign of the integrity patches.
> This patchset contains 4 patches.
> 	Patch 1/4 integrity: TPM internal kernel interface
> 	Patch 2/4 integrity: special fs magic
> 	Patch 3/4 integrity: Linux Integrity Module(LIM)
> 	Patch 4/4 integrity: IMA as an integrity service provider
>  
> Resubmitting integrity-tpm-internal-kernel-interface.patch, which
> was previously Signed-off-by Kylene Hall.
> 
> Adds the following support: 
> - internal kernel interface to transmit TPM commands
> - reading a pcr value
> - extending a pcr value
> - lookup the tpm_chip for given chip number and type
> 
> Signed-off-by: Mimi Zohar <zohar@...ibm.com>

>  /*
> - * Returns max number of jiffies to wait
> + * tpm_calc_ordinal_duration - returns max number of jiffies to wait
>   */
> -unsigned long tpm_calc_ordinal_duration(struct tpm_chip *chip,
> -					   u32 ordinal)
> +unsigned long tpm_calc_ordinal_duration(struct tpm_chip *chip, u32 ordinal)

Please don't mix real changes and cleanups... and lots of your changes
are just cleanups.

> @@ -544,7 +549,7 @@ duration:
>  	data[TPM_CAP_SUBCAP_IDX] = TPM_CAP_PROP_TIS_DURATION;
>  
>  	rc = transmit_cmd(chip, data, sizeof(data),
> -			"attempting to determine the durations");
> +			  "attempting to determine the durations");
>  	if (rc)
>  		return;
>

...like this.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/