linux-kernel - Re: [PATCH] edac: mpc85xx - Fix building as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 May 2008 09:13:10 -0700
From:	Dave Jiang <djiang@...sta.com>
To:	Kumar Gala <galak@...nel.crashing.org>
Cc:	dougthompson@...ssion.com, Andrew Morton <akpm@...l.org>,
	linuxppc-dev@...abs.org, bluesmoke-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] edac: mpc85xx - Fix building as a module

Acked-by: Dave Jiang <djiang@...sta.com>

Kumar Gala wrote:
> including of <asm/mpc85xx.h> causes build problems since it doesn't exist.
> 
> Also removed warning:
> drivers/edac/mpc85xx_edac.c:45: warning: 'mpc85xx_ctl_name' defined but not used
> 
> Signed-off-by: Kumar Gala <galak@...nel.crashing.org>
> ---
> 
> This is a fix for 2.6.26.
> 
> - k
> 
>  drivers/edac/mpc85xx_edac.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index 065732d..d49361b 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -20,7 +20,6 @@
> 
>  #include <linux/of_platform.h>
>  #include <linux/of_device.h>
> -#include <asm/mpc85xx.h>
>  #include "edac_module.h"
>  #include "edac_core.h"
>  #include "mpc85xx_edac.h"
> @@ -43,8 +42,6 @@ static u32 orig_pci_err_en;
>  static u32 orig_l2_err_disable;
>  static u32 orig_hid1;
> 
> -static const char *mpc85xx_ctl_name = "MPC85xx";
> -
>  /************************ MC SYSFS parts ***********************************/
> 
>  static ssize_t mpc85xx_mc_inject_data_hi_show(struct mem_ctl_info *mci,


-- 

------------------------------------------------------
Dave Jiang
Software Engineer
MontaVista Software, Inc.
http://www.mvista.com
------------------------------------------------------

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/