linux-kernel - Re: [patch 2/4] PNP: replace pnp_resource_table with dynamically allocated resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4835E337.4050501@keyaccess.nl>
Date:	Thu, 22 May 2008 23:18:47 +0200
From:	Rene Herman <rene.herman@...access.nl>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
CC:	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Adam Belay <ambx1@....rr.com>,
	Adam M Belay <abelay@....edu>,
	Li Shaohua <shaohua.li@...el.com>,
	Matthieu Castet <castet.matthieu@...e.fr>,
	Thomas Renninger <trenn@...e.de>,
	Jaroslav Kysela <perex@...ex.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Takashi Iwai <tiwai@...e.de>
Subject: Re: [patch 2/4] PNP: replace pnp_resource_table with dynamically
 allocated resources

On 20-05-08 01:41, Bjorn Helgaas wrote:

> On Monday 19 May 2008 05:14:07 pm Rene Herman wrote:

>>>  static void pnp_clean_resource_table(struct pnp_dev *dev)

[ ... ]

>> Do correct me if I'm wrong but I don't believe this will do. The index 
>> for the resources is preserved simply due to the list position after the 
>> DISABLED thing but here the list is reshuffled.
>>
>> So say I have an ISAPnP device with 2 port resources the second of which 
>> I force to manual setting through sysfs (ie, AUTO is cleared). This API 
>> would then delete the first port resource after which the second port 
>> resource is the first entry in the list which would make for example 
>> isapnp_set_resource() program it into hardware index 1, no?
> 
> My reasoning was that all AUTO entries should be at the end of the
> list, so deleting them should not change the order of other entries.

Yes, so it seems. You even said that in the changelog. Missed it, sorry.

Acked-by: Rene Herman <rene.herman@...il.com>

I have had your v2 series running on two machines (using PnPBIOS and 
ISAPnP) for a few days now and I haven't seen anything wrong. Looking 
good therefore. Good stuff!

Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/