linux-kernel - Re: [PATCH] linux-next: Tree for May 21 - build failure with netfilter on __nf_ct_helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080522101148.fbabee96.sfr@canb.auug.org.au>
Date:	Thu, 22 May 2008 10:11:48 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	netfilter-devel@...r.kernel.org, apw@...dowen.org,
	Franck Bui-Huu <fbuihuu@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] linux-next: Tree for May 21 - build failure with
 netfilter on __nf_ct_helper_find()

Hi all,

On Wed, 21 May 2008 18:59:01 +0530 Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com> wrote:
>
> Stephen Rothwell wrote:
> > 
> > Thanks for the report and patch.  This looks like it is probably broken in
> > Linus' kernel.  What config did you use to get the error?
> 
> Please find the .config file used to reproduce this build failure attached.

Actually this is caused by the splitting out of the rcu stuff from list.h
that is in linux-next, sorry.

Your patch looks good to me (reproduced below for new cc's).

Ingo, this should probably go into the rcu tree.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Date: Wed, 21 May 2008 17:02:30 +0530
From: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Subject: [PATCH] linux-next: Tree for May 21 - build failure with netfilter on __nf_ct_helper_find()

The next-20080521 kernel build fails, on x86_64 machine 

CC net/netfilter/nf_conntrack_helper.o
net/netfilter/nf_conntrack_helper.c: In function ‘__nf_ct_helper_find’:
net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function ‘hlist_for_each_entry_rcu’
net/netfilter/nf_conntrack_helper.c:58: error: ‘hnode’ undeclared (first use in this function)
net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identifier is reported only once
net/netfilter/nf_conntrack_helper.c:58: error: for each function it appears in.)
net/netfilter/nf_conntrack_helper.c:58: error: expected ‘;’ before ‘{’ token
net/netfilter/nf_conntrack_helper.c:50: warning: unused variable ‘mask’
net/netfilter/nf_conntrack_helper.c: In function ‘__nf_conntrack_helper_find_byname’:
net/netfilter/nf_conntrack_helper.c:74: error: ‘hnode’ undeclared (first use in this function)
net/netfilter/nf_conntrack_helper.c:74: error: expected ‘;’ before ‘{’ token
net/netfilter/nf_conntrack_helper.c: In function ‘nf_conntrack_helper_register’:
net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of function ‘hlist_add_head_rcu’
net/netfilter/nf_conntrack_helper.c: In function ‘nf_conntrack_helper_unregister’:
net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of function ‘hlist_del_rcu’
make[2]: *** [net/netfilter/nf_conntrack_helper.o] Error 1
make[1]: *** [net/netfilter] Error 2
make: *** [net] Error 2

This build error is because of the missing include file.I have tested
the patch for the build failure only.

Signed-off-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
--
--- linux-2.6.26-rc3/net/netfilter/nf_conntrack_helper.c	2008-05-20 20:24:14.000000000 +0530
+++ linux-2.6.26-rc3/net/netfilter/~nf_conntrack_helper.c	2008-05-22 00:17:32.000000000 +0530
@@ -20,6 +20,7 @@
 #include <linux/err.h>
 #include <linux/kernel.h>
 #include <linux/netdevice.h>
+#include <linux/rculist.h>
 
 #include <net/netfilter/nf_conntrack.h>
 #include <net/netfilter/nf_conntrack_l3proto.h>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/