linux-kernel - Re: [PATCH] serial: fix enable_irq_wake/disable_irq_wake imbalance in serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4834EFA9.6050407@linux.intel.com>
Date:	Wed, 21 May 2008 20:59:37 -0700
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, alan@...rguk.ukuu.org.uk
Subject: Re: [PATCH] serial: fix enable_irq_wake/disable_irq_wake imbalance
 in serial_core.c

Andrew Morton wrote:
>>  	}
>>  
>> -	if (!port->suspended) {
>> +	tty_dev = device_find_child(port->dev, &match, serial_match_port);
>> +	if (!port->suspended && device_may_wakeup(tty_dev)) {
>>  		disable_irq_wake(port->irq);
>>  		mutex_unlock(&state->mutex);
>>  		return 0;
> 
> erp, is that the easiest way of going from a uart_driver* to a device*?
> Doing a lookup each time is a bit unusual.
> 

this is during suspend/resume only, so I figured it wasn't going to be that performance critical;
I wanted the code to be as symmetric as possible rather than fastest..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/