[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <4836AC3C.3090005@in.ibm.com>
Date: Fri, 23 May 2008 17:06:28 +0530
From: Sharyathi Nagesh <sharyath@...ibm.com>
To: linux-kernel@...r.kernel.org, fastboot@...ts.osdl.org,
akpm@...l.org, maneesh@...ltcfwd.linux.ibm.com,
ebiederm@...ssion.com, mohan@...ibm.com, sachinp@...ibm.com
CC: mohd.omar@...ibm.com, IndhuDurai@...ibm.com
Subject: correction to compat_sys_kexec_load
Hi
While testing with kexec tool, I observed some problems. When
application (kexec) is 32 bit and kernel is 64 bit I observed that
loading crash kernel works without any issues but unloading crash kernel
fails.
--------------------------------------------------------
running strace over 'kexec -u -p'
show the problem to be with sys_kexec_load() call
sys_kexec_load(0, 0, 0, 0x1, 0) = -1 EINVAL (Invalid argument)
write(2, "kexec_load (0 segments) failed: "..., 49
kexec_load (0 segments) failed: Invalid argument
) = 4
--------------------------------------------------------
This is patch to fix the problem, I think kernel code had a typo where in:
if((flags & KEXEC_ARCH_MASK) == KEXEC_ARCH) was used instead of
if((flags & KEXEC_ARCH_MASK) != KEXEC_ARCH)
This patch takes care of that, I have tested the patch it worked fine
for me. Please review the patch and let me know of your views. This
patch is based on linux-2.6.26-rc3.
Thanks
Yeehaw
View attachment "compat_sys_kexec_correction.patch" of type "text/x-patch" (597 bytes)
Powered by blists - more mailing lists