linux-kernel - Re: [PATCH] x86: early dump pci conf space v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200805230830.28699.jbarnes@virtuousgeek.org>
Date:	Fri, 23 May 2008 08:30:28 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Grant Grundler <grundler@...isc-linux.org>
Cc:	Yinghai Lu <yhlu.kernel@...il.com>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-pci@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: early dump pci conf space v2

On Thursday, May 22, 2008 10:38 pm Grant Grundler wrote:
> On Thu, May 22, 2008 at 02:35:11PM -0700, Yinghai Lu wrote:
> > so we can printout pci config before kernel touch it
> >
> > Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>
>
> Yinghai,
> No offense, but my first thought was this is debug code that should be
> maintained outside the kernel.org tree. It will rarely get used.
> Just want people to think about this before saying "great, add it!"
>
> (And this isn't a stab at Jesse since I think he's doing a better
> job than I could. I saw his previous reply to this mail.)
>
> Having debugged lots of PCI resource and config issues, I understand
> why this is useful and do NOT object to it being included in the tree.

Yeah I thought about this too, but:
  1) it's definitely useful for debugging PCI issues, and much easier for 
everyone if it's in-tree
  2) it only bloats x86 kernels ;)

Documentation is definitely needed though, thanks for catching that.

Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/