linux-kernel - Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <79373BC9-13F5-45BE-8D51-527F70D00094@holtmann.org>
Date:	Sat, 24 May 2008 21:31:45 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org,
	aoliva@...hat.com, alan@...rguk.ukuu.org.uk,
	Abhay Salunke <Abhay_Salunke@...l.com>, kay.sievers@...y.org,
	Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option

Hi David,

>>>> Playing with it now. I fixed the mkdir thing by including $ 
>>>> (objtree)
>>>> in the target.
>>>
>>> Here's what I have (on top of the git tree) now. I just need to sort
>>> out
>>> the clean/mrproper behaviour -- and possibly should rename the korg
>>> firmware to firmware/korg/k1212.c_shipped?
>>
>> so using "/" within the name parameter for request_firmware() is
>> actually forbidden. I know that some driver authers think it is a  
>> good
>> idea, but it is not.
>>
>> I am actually working on a patch to make request_firmware() fail/warn
>> when the name has a "/" in it.
>>
>> You don't need to consider any deep nesting of firmware file names.  
>> It
>> was never meant to be used like this.
>
> Hm. Is there any fundamental reason why we should forbid this? It does
> seem to make sense to let people use the namespace for it.

I explained this a couple of times. The request_firmware() is an  
abstract mechanism that can request a firmware file. The location of  
the firmware file is up to the userspace. The kernel requests a  
particular file and that is it. All namespacing has to be done by the  
firmware helper script (nowadays udev). That the current  
implementation of the firmware helper maps the filename 1:1 to a file  
under /lib/firmware/ just works, but doesn't have to work all the  
time. It is not the agreed contract between kernel and userspace.

If you wanna do namespacing then you have to do it within the firmware  
helper script. For example the helper script could look for /lib/ 
firmware/<driver>/<filename> instead of /lib/firmware/<filename>.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/