linux-kernel - Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5779f808f6188a88231bf2a8c49e52d5@kernel.crashing.org>
Date:	Sun, 25 May 2008 01:06:08 +0200
From:	Segher Boessenkool <segher@...nel.crashing.org>
To:	"Grant Likely" <grant.likely@...retlab.ca>
Cc:	linux-kernel@...r.kernel.org, Pierre Ossman <drzeus-mmc@...eus.cx>,
	"Anton Vorontsov" <avorontsov@...mvista.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Gary Jennejohn <garyj@...x.de>, linuxppc-dev@...abs.org
Subject: Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc_spi driver

>> +      Required properties:
>> +      - #address-cells : should be 0.
>> +      - #size-cells : should be 0.
>
> Are these properties required at all?  Will this node have any 
> children.

You mean, "does this node define a bus".  If it doesn't, there
shouldn't be #a and #s; if it does, the binding should describe
what the addressing is.  #a = #s = 0 describes a bus without any
addressing; pretty unusual :-)

>> +      - linux,mmc-ocr-mask : (optional) Linux-specific MMC OCR mask
>> +        (slot voltage).
>
> Should this property be better defined?

Yes please.  There's a good chance that it doesn't turn out to be
Linux-specific at all (after some modification, perhaps).


Segher

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/