linux-kernel - Re: [PATCH 1/2] Use structs instead of hardcoded offsets in x86 boot decompressor.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4838E5D4.4050708@zytor.com>
Date:	Sat, 24 May 2008 21:06:44 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Rik van Riel <riel@...hat.com>
CC:	Kristian Høgsberg <krh@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Use structs instead of hardcoded offsets in x86 boot
 decompressor.

Rik van Riel wrote:
> On Fri, 23 May 2008 23:17:01 -0700
> "H. Peter Anvin" <hpa@...or.com> wrote:
> 
>> Uhm... except it doesn't live at address zero, at all.
>>
>> It's called "zeropage" because we used to recycle it into 
>> empty_zero_page, a long long time ago.
>>
>> The bootparms structure is pointed to by %esi being passed from the 
>> setup code to the decompressor to the kernel.
> 
> Then why does dereferencing the uninitialized
> pointer work, both in the code before and after
> the patch?
> 
> What am I misssing?

Heck if I know.  It definitely *shouldn't* work...

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/