linux-kernel - Re: [PATCHv2 04/28] cx25840: treat firmware data as const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <483990F3.5070507@gmail.com>
Date:	Sun, 25 May 2008 12:16:51 -0400
From:	Tyler Trafford <ttrafford@...il.com>
To:	Mike Isely <isely@...ox.com>
CC:	Hans Verkuil <hverkuil@...all.nl>,
	David Woodhouse <dwmw2@...radead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	sam@...nborg.org, Alan Cox <alan@...rguk.ukuu.org.uk>,
	akpm@...ux-foundation.org
Subject: Re: [PATCHv2 04/28] cx25840: treat firmware data as const

[cx25840-firmware.c]

Looks good to me.

Acked-By: Tyler Trafford <ttrafford@...il.com>

Mike Isely wrote:

> I see that this change allocates a local buffer on the stack (sized by 
> FWSEND).  Though the buffer is small (48 bytes, see above paragraph), it 
> is controlled by a macro and thus leaves open the possibility that it 
> could be accidentally increased to a point where the stack gets 
> overflowed.  Seems like not a good idea, but either way it should not 
> affect the pvrusb2 driver.

Separate topic, but maybe the send size should be parameterized, so that 
the adapter can specify a maximum?
-- 
Tyler Trafford

A sect or party is an elegant incognito devised to save a man from
the vexation of thinking.
		-- Ralph Waldo Emerson, Journals, 1831
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/