linux-kernel - Re: [PATCH] SERIAL: Simplify code using ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0805251308420.25842@localhost.localdomain>
Date:	Sun, 25 May 2008 13:09:21 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...shcourse.ca>
To:	Jiri Slaby <jirislaby@...il.com>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] SERIAL:  Simplify code using ARRAY_SIZE() macro.

On Sun, 25 May 2008, Jiri Slaby wrote:

> On 05/25/2008 01:37 PM, Robert P. J. Day wrote:
> > Signed-off-by: Robert P. J. Day <rpjday@...shcourse.ca>
> >
> > ---
> >
> >  drivers/serial/68328serial.c |    6 +++---
> >  drivers/serial/mcfserial.c   |    5 ++---
> >  2 files changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/serial/68328serial.c b/drivers/serial/68328serial.c
> > index bbf5bc5..71c56c1 100644
> > --- a/drivers/serial/68328serial.c
> > +++ b/drivers/serial/68328serial.c
> [...]
> > @@ -1413,10 +1413,10 @@ static void m68328_set_baud(void)
> >  	USTCNT = ustcnt & ~USTCNT_TXEN;
> >
> >  again:
> > -	for (i = 0; i < sizeof(baud_table) / sizeof(baud_table[0]); i++)
> > +	for (i = 0; i < BAUD_TABLE_SIZE); i++)
>
> typo? does this compile?

oh, gack, my bad.  it compiled, then i figured i'd innocently fix up
some white space and pooched it.  sorry.  will resubmit.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/