linux-kernel - Re: [patch 04/14] gfs2: dont call permission()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080525192414.GB1949@infradead.org>
Date:	Sun, 25 May 2008 15:24:14 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	hch@...radead.org, linux-fsdevel@...r.kernel.org,
	viro@...IV.linux.org.uk, linux-kernel@...r.kernel.org,
	swhiteho@...hat.com
Subject: Re: [patch 04/14] gfs2: dont call permission()

On Fri, May 23, 2008 at 12:00:26PM +0200, Miklos Szeredi wrote:
> And that's true of lookup_one_len() as well, the last bit of horror
> left in this permission() saga.  It's called from lots of places,
> often for doing things it's not at all meant to do (e.g. where caller
> _knows_ it will return negative, etc...).  One day maybe I'll have
> strength to clean that up as well..., but not now.

lookup_one_len is not just a horror for permission, it's a nighmare
in general.  I'm not convinced any use of it except for silly renames
is actually valid.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/